fix(intent): keep the ADMINISTRATOR candidate-group default for .settings files that predate userTasks - #6341
Merged
Conversation
…ings files that predate userTasks A settings document without a userTasks section now gets the same ADMINISTRATOR candidateGroupsExtra default that scaffolding writes - the deserialized POJO cannot distinguish an absent section from an explicitly empty one, so parse() checks the raw document for the member (a null member counts as absent). An explicit block - including an explicitly empty list, a deliberate opt-out - is kept verbatim. Without this, every module whose developer-owned .settings was scaffolded before the userTasks setting existed silently emitted user tasks with the authored role as the ONLY candidate group: the task existed in ACT_RU_TASK with a single candidate identity link, invisible to every administrator inbox, while the process showed the token parked at the task. Fixes #6338. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6338 - see the issue for the full field diagnosis (task in
ACT_RU_TASKwith a loneAgentidentity link, invisible to every inbox query while/instance/{id}/activeshows the token AT the task).IntentSettings.parseapplies the scaffold'sADMINISTRATORdefault when the raw document has nouserTasksmember (anullmember counts as absent). The POJO alone can't tell absence from an explicit empty list, so the raw JSON is consulted.userTasksblock is kept verbatim - including an explicitly emptycandidateGroupsExtra: [], the deliberate opt-out.IntentSettingsTestcovers absent / empty-document / null-member / explicit-empty / explicit-list. Full engine-intent unit suite green.🤖 Generated with Claude Code