Skip to content

fix(intent-editor): keep Generate clickable after a cross-model failure #6298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iliyan-velichkov merged 1 commit into from
Jul 15, 2026
Merged

fix(intent-editor): keep Generate clickable after a cross-model failure #6298

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion components/ui/editor-intent/src/main/resources/META-INF/dirigible/editor-intent/editor.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,7 @@
<bk-toolbar-separator></bk-toolbar-separator>
<bk-button state="transparent" glyph="sap-icon--save" title="Save" aria-label="Save" ng-click="save()" ng-disabled="!changed || state.isBusy"></bk-button>
<bk-toolbar-separator></bk-toolbar-separator>
<bk-button state="emphasized" glyph="sap-icon--generate-shortcut" label="Generate" title="Generate the model files into the project" aria-label="Generate" ng-click="generate()" ng-disabled="state.isBusy || issues.length"></bk-button>
<bk-button state="emphasized" glyph="sap-icon--generate-shortcut" label="Generate" title="Generate the model files into the project" aria-label="Generate" ng-click="generate()" ng-disabled="state.isBusy"></bk-button>
<bk-toolbar-separator></bk-toolbar-separator>
<bk-button state="{{chat.open ? 'emphasized' : 'transparent'}}" glyph="sap-icon--discussion" title="AI assistant" aria-label="AI assistant" ng-click="toggleChat()"></bk-button>
</bk-toolbar>
Expand Down
7 changes: 4 additions & 3 deletions components/ui/editor-intent/src/main/resources/META-INF/dirigible/editor-intent/js/editor.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,9 +248,9 @@ editorView.controller('IntentEditorController', ($scope, $http, ViewParameters,

// Re-parse and re-validate the current buffer on demand. Generate resolves cross-model
// dependencies against other projects' already-generated .model files; when one is missing it
// fails with issues that stay pinned (blocking Generate) until the buffer is re-parsed. After
// generating the dependency project, Refresh clears those stale issues and re-renders — no browser
// reload needed.
// fails with issues that stay pinned in the strip until the buffer is re-parsed (Generate itself
// stays clickable — it re-validates server-side). After generating the dependency project,
// Refresh clears those stale issues and re-renders — no browser reload needed.
$scope.refresh = () => {
refreshPreview().then(() => {
statusBarHub.showMessage('Re-validated the intent');
Expand Down Expand Up @@ -319,6 +319,7 @@ editorView.controller('IntentEditorController', ($scope, $http, ViewParameters,
dialogHub.showBusyDialog('Generating model files');
$http.post(`${GENERATE_URL}?workspace=${encodeURIComponent(location.workspace)}&project=${encodeURIComponent(location.project)}&path=${encodeURIComponent(location.path)}`)
.then((response) => {
$scope.issues = []; // a successful generate clears any pinned cross-model issue from a prior attempt
const written = (response.data.written || []).length;
const scrubbed = (response.data.scrubbed || []).length;
const plan = response.data.codeGenerations || [];
Expand Down
Loading