Repository navigation
Point repository references to eclipse-aascw - #98
Merged
Merged
Conversation
The repository moved from aas-core-works to eclipse-aascw. npm checks that package.json's repository.url matches the repository a provenance statement was built in, so publishing with --provenance from the new location requires the new URL. The publish workflow only committed the synced package versions back to main when running in aas-core-works/aas-package3-typescript, so that step has been skipped since the move. The README badges and the link check ignore pattern are updated as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The npm publish for the v1.1.0 release (run 38377133716) failed with:
The repository moved from
aas-core-workstoeclipse-aascw, but some settings still refer to the old location:aas-core-works/aas-package3-typescript, while the OIDC token now identifieseclipse-aascw/aas-package3-typescript. npm answers that mismatch with the 404 above. v1.0.0's provenance confirms it was built inaas-core-works.repository.urlinpackage.json. With--provenance, npm checks thatrepository.urlmatches the repository the provenance was built in. Without this change, the next publish would fail at that check.publish.yml. The "Commit synced package files" step only runs whengithub.repository == 'aas-core-works/aas-package3-typescript', so it has been skipped since the move. That's whypackage.jsononmainstill says1.0.0.Change
package.json:repository.urlnow points toeclipse-aascw.publish.yml: the repository condition of the sync step now nameseclipse-aascw.No library code changes. Typecheck, lint and tests pass.
Releasing 1.1.0 after merge
eclipse-aascw, repositoryaas-package3-typescript, workflowpublish.yml.repository.url.