Repository navigation
Support in on lists and strings - #850
Merged
Merged
Conversation
We support the membership ``in`` a list, *e.g.*, ``number in seen``, and in a string, *e.g.*, ``"." in text``, in all the targets. Go uses a new ``ourcommon.SliceContains``, which compares as ``any``, since the interfaces satisfy ``comparable`` only from Go 1.20 on, and ``strings.Contains``. C++ checks for a sub-string with ``text.find(sub) != std::wstring::npos``. We look up the lists of integers with ``Long``'s in Java, *e.g.*, ``getSomeInts().contains(0L)``, as the boxed ``Integer``'s are never equal to any ``Long``. We refuse the byte arrays as members of ``in``, since Python compares them byte by byte, C# and Java by reference, and Go can not compare them at all. We refuse the JSON-able values as members in a list for the same reason.
Coverage Report for CI Build 38800852661Warning Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes. Coverage increased (+0.02%) to 90.147%Details
Uncovered Changes
Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We support the membership
ina list, e.g.,number in seen, and in a string, e.g.,"." in text, in all the targets. Go uses a newourcommon.SliceContains, which compares asany, since the interfaces satisfycomparableonly from Go 1.20 on, andstrings.Contains. C++ checks for a sub-string withtext.find(sub) != std::wstring::npos.We look up the lists of integers with
Long's in Java, e.g.,getSomeInts().contains(0L), as the boxedInteger's are never equal to anyLong.We refuse the byte arrays as members of
in, since Python compares them byte by byte, C# and Java by reference, and Go can not compare them at all. We refuse the JSON-able values as members in a list for the same reason.