Repository navigation
Support list literals and append - #849
Merged
Merged
Conversation
We support list literals, *e.g.*, ``for prime in [2, 3, 5, 7]:``, and ``append`` on local lists, *e.g.*, ``result.append(len(text))``, in all the targets, so that the meta-model can build lists in the verification functions. An empty list literal needs a declared type, *e.g.*, ``result: List[int] = []``. We allow ``append`` only on a local list variable which is never aliased. Go appends with ``items = append(items, item)``, which gives a new slice whenever the array beneath has to grow, and C++ copies the lists on assignment, so the aliases would diverge from Python. We also infer in Go the is-pointer of the collection of a generator, which crashed on ``all(... for x in f(self.y))``.
Coverage Report for CI Build 38797701430Coverage decreased (-0.02%) to 90.127%Details
Uncovered Changes
Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We support list literals, e.g.,
for prime in [2, 3, 5, 7]:, andappendon local lists, e.g.,result.append(len(text)), in all the targets, so that the meta-model can build lists in the verification functions. An empty list literal needs a declared type, e.g.,result: List[int] = [].We allow
appendonly on a local list variable which is never aliased. Go appends withitems = append(items, item), which gives a new slice whenever the array beneath has to grow, and C++ copies the lists on assignment, so the aliases would diverge from Python.We also infer in Go the is-pointer of the collection of a generator, which crashed on
all(... for x in f(self.y)).