Repository navigation
Include fstream in C++ tests reading files - #848
Merged
Merged
Conversation
Since #846, the generated tests no longer define ``CATCH_CONFIG_MAIN``, so ``catch.hpp`` no longer brings in ``<fstream>``, and clang refuses ``test_verification.cpp`` and ``test_xmlization_of_concrete_classes.cpp`` with ``implicit instantiation of undefined template 'std::basic_ifstream<char>'``. We include ``<fstream>`` explicitly in both tests, which use ``std::ifstream``.
Coverage Report for CI Build 38774558943Coverage remained the same at 90.142%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
mristin
deleted the
mristin/Include-fstream-in-C++-tests-reading-files
branch
October 15, 2026 18:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #846, the generated tests no longer define
CATCH_CONFIG_MAIN, socatch.hppno longer brings in<fstream>, and clang refusestest_verification.cppandtest_xmlization_of_concrete_classes.cppwithimplicit instantiation of undefined template 'std::basic_ifstream<char>'. We include<fstream>explicitly in both tests, which usestd::ifstream.