Repository navigation
Conversation
We reported the errors in the items of the lists, the sets and the tuples
with a redundant segment of the item element in C++, *e.g.*,
``texts/*[0]/v`` instead of ``texts/*[0]``, as the item readers prepended
the element segment and the containers prepended the index on top of it.
The index already selects the item element, so we now replace the element
segment with the index, and report the same paths as the other SDKs:
texts/*[0]/v -> texts/*[0]
items/*[1]/someItem/x -> items/*[1]/x
pair/*[0]/v1 -> pair/*[0]
Coverage Report for CI Build 38167007250Coverage increased (+0.001%) to 90.14%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We reported the errors in the items of the lists, the sets and the tuples with a redundant segment of the item element in C++, e.g.,
texts/*[0]/vinstead oftexts/*[0], as the item readers prepended the element segment and the containers prepended the index on top of it. The index already selects the item element, so we now replace the element segment with the index, and report the same paths as the other SDKs: