Repository navigation
Allow functions without arguments - #836
Merged
Merged
Conversation
The parser rejected all the functions without arguments, though
a verification function can operate on constants alone, as in:
@verification
def seven_is_lucky() -> bool:
return 7 in Lucky_numbers
We now allow them, and leave it to the existing ``expect_self`` check to
reject the methods without ``self``.
We also fix the generators for this case. TypeScript rendered
``function foo(): boolean:`` instead of ``function foo(): boolean {``,
and C++ rendered an empty line between the parentheses.
We test it with ``seven_is_lucky`` in the ``sets`` meta-model.
Coverage Report for CI Build 37155591089Coverage increased (+0.02%) to 90.135%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The parser rejected all the functions without arguments, though a verification function can operate on constants alone, as in:
We now allow them, and leave it to the existing
expect_selfcheck to reject the methods withoutself.We also fix the generators for this case. TypeScript rendered
function foo(): boolean:instead offunction foo(): boolean {, and C++ rendered an empty line between the parentheses.We test it with
seven_is_luckyin thesetsmeta-model.