Repository navigation
Fix signatures of methods with two arguments - #835
Merged
mristin merged 1 commit intoOct 3, 2026
Merged
Conversation
The C#, Java and TypeScript interfaces rendered the public methods with more than two arguments on multiple lines, with exactly one on a single line, and otherwise asserted that there were no arguments. Hence a method with exactly two arguments failed the assertion. We now split ``if len(arg_codes) > 1:``. The Go enhancing joined the arguments with ``,`` although each already ended with one, rendering ``low int64,,high int64,``. We now join them with new lines. We test it with ``Item.is_count_between(self, low, high)`` in the ``transpiled_methods`` meta-model.
Coverage Report for CI Build 37153715928Coverage increased (+0.02%) to 90.12%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
mristin
deleted the
mristin/Fix-signatures-of-methods-with-two-arguments
branch
October 3, 2026 21:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The C#, Java and TypeScript interfaces rendered the public methods with more than two arguments on multiple lines, with exactly one on a single line, and otherwise asserted that there were no arguments. Hence a method with exactly two arguments failed the assertion. We now split
if len(arg_codes) > 1:.The Go enhancing joined the arguments with
,although each already ended with one, renderinglow int64,,high int64,. We now join them with new lines.We test it with
Item.is_count_between(self, low, high)in thetranspiled_methodsmeta-model.