Repository navigation
feat: inspect tool input and output independently - #54
Merged
Merged
Conversation
Co-authored-by: OpenAI Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expanded tool cards show output first, with independent Input and Output disclosure controls. Each card retains its choices while virtualised transcript rows recycle, and Copy remains available for closed sections.
Part of #2
Closes #53
Verification
bun install --frozen-lockfilepassed.mise exec -- bun run lintpassed.mise exec -- bun run typecheckpassed.mise exec -- bun run test:unitpassed, 90 tests.mise exec -- bun run test:integrationpassed, 60 tests.mise run buildpassed.mise exec -- bun run test:e2epassed, 47 tests across five Electron suites.git diff --checkpassed.Proof
The new Electron test,
inspects tool sections independently and retains choices after row recycling, checks initial visibility, Enter and Space activation, exact native clipboard contents, actual row removal from the DOM and restored disclosure choices. New component tests also pass alongside the existing diff, copy and truncation cases.opens output first and toggles input and output independentlykeeps closed output hidden during streaming and reveals the latest resultrestores section choices after remounting without changing other cardsshows empty input and output explanations when their sections are openPlaywright captured the running Electron app in
.tmp/proof/tool-output-first.pngand.tmp/proof/tool-input-restored.png. The E2E suite also writes both images totest-results/long-session/for the existingpidex-e2eCI artefact upload. Both local images were visually inspected.test-results/long-session/tool-output-first.pngandtest-results/long-session/tool-input-restored.pnginside the archive, underUsers/runner/work/pidex/pidex/. The downloaded CI artefact was checked for both images.The local Electron installation needed its install script rerun with pinned Node 22 before launch. The native browser attachment service is unavailable in this environment, so inline GitHub image attachment is blocked; screenshots are supplied through the CI artefact instead. Captures and scratch logs are excluded from the commit.
Section choices last only while the transcript stays open. Durable reading preferences and richer tool-specific output remain follow-up slices under #2. Pi execution and archive formats are unchanged.