Repository navigation
fix: count each body region once per workout - #44
Merged
Merged
Conversation
Co-authored-by: OpenAI Codex <noreply@openai.com>
Contributor
Author
|
Captured the recovery regression before and after the fix. Before the fix After the fix All final repository gates passed: |
This was referenced Nov 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A recorded workout now applies one fatigue transition per distinct body region. Compound exercises and multiple exercises targeting the same region no longer mark it sore during the first session; separate sessions still increase fatigue.
Completes the per-workout region counting slice. Part of #5. Closes #43.
Verified locally with the repository gates, all exiting 0 after the fix.
mise run lintpassed with 0 serious violations and 491 existing warnings.mise run buildpassed.mise run testpassed with 151 XCTest tests and 22 Swift Testing tests, including the parameterised regression cases below and the existing video pipeline smoke checks.git diff --checkpassed.mise run buildandmise run teston Linux,mise run lintandmise run ios:build:ci,mise run ios:coverage, andmise run ios:e2e. View the completed CI run.The uploaded proof transcript records the local behaviour checks.
The regression run before the fix failed as expected. One squat targeting quads and glutes produced sore legs, where the regression expected fatigued legs.
The final unit and integration test capture shows compound exercises, repeated muscles, several exercises in one session, separate workouts, pre-existing fatigue and untargeted regions.
testCompleteWorkoutFlowchecks the result through the BetterFit facade as well as history and streak updates.No app UI or layout changed. Unit and integration output was the successful capture method for this core logic slice; local simulator screenshots and local XCUITest captures were not attempted. CI also passed the full simulator test suites. Scratch logs remain under
.tmp/proof/and are not committed.The CI simulator capture also confirms the recovery insights screen still runs, with all 27 UI tests passing.
Recovery timing, completed-set weighting, persisted historical fatigue values and equipment substitution remain follow-up work under #5. This change preserves the current API and Codable format.