Repository navigation
chore: align TypeScript and enforce compiler checks - #133
Merged
Merged
Conversation
Match the Backstage 1.56.5 compiler baseline and run a clean workspace type check before ESLint in the existing CI gate. Co-authored-by: OpenAI Codex <noreply@openai.com>
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TypeScript now uses
~5.8.0in the root and GitHub theme workspaces, matching the Backstage 1.56.5 app template.mise run typecheckchecks workspace source without emitting files or using an incremental cache, andmise run lintruns that check before ESLint so the existing PR workflow catches compiler failures.Part of #85. Closes #131. The parent epic stays open.
This slice changes development tooling and dependencies. Nothing user-facing changed, so browser capture is not applicable and no screenshot was fabricated. Command transcripts provide the evidence.
All commands below ran with
MISE_TRUSTED_CONFIG_PATHS="$PWD"for this fresh worktree.mise run installpassed with existing peer dependency warnings.CI=true mise run installpassed with the immutable lockfile check.mise run typecheck --versionreported TypeScript 5.8.3.mise run typecheckpassed with no source errors.mise run lintpassed across all five workspaces after the compiler check.mise run test --runInBand --verbosepassed with 45 tests across seven suites. One existing test/suite remains skipped.mise run buildpassed and built the local Docker image in 302.93 seconds. Docker was initially stopped; starting the installed Docker Desktop resolved that environment blocker. No image was pushed.Before the update, the compiler rejected Backstage's
DOM.AsyncIterablelibrary with TS6046. After the update, both typecheck and lint rejected a temporarynumbervariable assigned a string with TS2322 and exit code 2. The probe was removed, the clean lint gate passed again, and nodist-typesdirectory was emitted. No application source or compiler strictness settings changed.The source check retains Backstage's inherited
skipLibCheckdefault. Existing peer dependency and test-console warnings remain. Yarn 4.3.1 also reported optional TypeScript patch warnings in Docker; dependency installation and the backend build still passed. The development guide documents the new task and compiler alignment for future upgrades.Pre-merge verification on 13 November 2026
Rechecked commit
dab35efin a fresh scheduled-run worktree. The branch already containsorigin/mainat48e4714, so no rebase was needed. No code changes were required, and the working tree stayed clean.All four gates passed again with
MISE_TRUSTED_CONFIG_PATHS="$PWD".The existing peer dependency and test-console warnings remain. All five PR checks are green, including the CI build transcript. Transcript evidence succeeded. Browser capture is not applicable because nothing user-facing changed; no capture path was blocked.