Repository navigation
fix: make showcase filters accessible and resettable - #132
Merged
Merged
Conversation
Co-authored-by: OpenAI Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The showcase search now has a visible label, category buttons expose their selected state, and the result count uses a polite status region. Empty results offer Clear filters, which resets both filters and returns focus to search; the search field also fits narrow screens.
Part of #86. Closes #130 after merge. The parent epic stays open.
Verified with the repository gates and a running local stack.
mise run installpassed with existing peer dependency warnings.mise run lintpassed across all workspaces, including 51 app files.mise run test --runInBand --verbosepassed with 45 tests across seven suites; one existing test/suite remains skipped.BROWSER=none mise run devcompiled successfully and served the app and backend on 3010/7017 through gitignored local configuration. Another worktree already owns 3000/7007.mise run proof-browser run-codepassed browser assertions for Space-key category selection, combined filtering, Enter-key reset, all 14 cards returning and focus returning to search. At 375px, the search field stays inside the viewport and reset restores all cards. The temporary local proof-browser task used the installed Playwright CLI with Chrome.The new behaviour tests passed.
Browser capture succeeded on desktop and mobile. No capture method was blocked and no fallback was needed. Screenshots are committed under
.tmp/proof/and linked to this exact commit.An extra
mise run check-typescheck, using a temporary local task that executesnode node_modules/typescript/bin/tsc --incremental false, failed before checking application code. The existing TypeScript ~5.3.0 cannot acceptDOM.AsyncIterablefrom Backstage's compiler defaults (TS6046). The dependency and compiler configuration files match origin/main at 2cdb9eb. Follow-up #131 tracks compiler compatibility and a repository type-check gate; the current lint task runs ESLint only. No manual screen reader session was performed; automated checks verify the accessible names, pressed states, status semantics and keyboard focus behaviour.