[#39] Add de-duplication code for restore with no options - #45
Open
marxjohnson wants to merge 1 commit into
Open
[#39] Add de-duplication code for restore with no options#45marxjohnson wants to merge 1 commit into
marxjohnson wants to merge 1 commit into
Conversation
If we end up restoring a question from a backup that had its original options record deleted, it will duplicate that question. This fix ensures that such a question will use defaults provided by `get_default_options()` to correctly match it with the original question, avoiding duplication. This is largely copied from the same functionality added to qtype_multichoice for MDL-85721. The existing create_default_options() function relied on some plugin config for some of the default values, but there doesn't appear to be a way to set these config settings, so I have replaced them with hard-coded values.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we end up restoring a question from a backup that had its original options record deleted, it will duplicate that question. This fix ensures that such a question will use defaults provided by
get_default_options()to correctly match it with the original question, avoiding duplication.This is largely copied from the same functionality added to qtype_multichoice for MDL-85721.
The existing create_default_options() function relied on some plugin config for some of the default values, but there doesn't appear to be a way to set these config settings, so I have replaced them with hard-coded values.