Skip to content

refactor: update comment in G_RadiusDamage #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
WofWca wants to merge 1 commit into
base: master
Choose a base branch
from
Open

refactor: update comment in G_RadiusDamage #76

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions code/game/g_combat.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1205,13 +1205,14 @@ qboolean G_RadiusDamage ( gentity_t *self, vec3_t origin, gentity_t *attacker, f

// Put the attacker and their team members at the beginning of the list
// so that we damage them first, to make for more deterministic behavior.
// Otherwise if 1 frag left for the attacker and they both frag and suicide
// with this missile then they may or may not win,
// depending on the order returned from `trap_EntitiesInBox`,
// Otherwise the order returned from `trap_EntitiesInBox` is used,
// which is not defined (or at least is not relevant to us here).
//
// Note, however, that during sudden death this situation will result
// in the attacker's team losing.
// The order in which players get killed used to affect who wins
// if this explosion kills both an enemy and self,
// but now we have `CheckExitRulesLater()`,
// so the order here is no longer relevant in that regard.
// However, having consistency is still nice, so let's keep this code.
//
// An alternative would be to sort by distance,
// which is what e.g. ETLegacy does:
Expand Down