Bug fix for propagation of pstmtCacheSize and cstmtCacheSize from mai…#148
Merged
Conversation
…n to readOnly Datasource Currently this propagation doesn't happen and when we reduce the pstmtCacheSize size on a main datasource this isn't propagated to the readonly one. This was picked up with a CI build failure with oracle, when the default pstmtCacheSize bumped to 300, this has meant it hits a too-many-cursors error with the CI Oracle build for ebean.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…n to readOnly Datasource
Currently this propagation doesn't happen and when we reduce the pstmtCacheSize size on a main datasource this isn't propagated to the readonly one.
This was picked up with a CI build failure with oracle, when the default pstmtCacheSize bumped to 300, this has meant it hits a too-many-cursors error with the CI Oracle build for ebean.