Fixed the EventLoop function#29
Conversation
…ot the interface)
|
Hi @yourfavDev, would you elaborate on the problem and how to reproduce it? I'm not exactly following. |
|
Hi, @ebarlas when importing the repo to intellij it seems that it used the java handler instead of the one created inside the repo, the only thing i changed was to explicitly mention the custom handler |
|
Also printStackTrace is not rpefferred for catching exceptions this is why i modified to getStackTrace. Injust saw now that itnellij imported the java handler in some files apart from that everything should be fine |
|
I just updated the GitHub workflow build.yml file to use OpenJDK 24. The build passes fine. Whatever you're encountering is specific to your environment. |
|
|
||
| class Task implements Cancellable { | ||
| class Task | ||
| implements Cancellable { |
There was a problem hiding this comment.
can this be corrected like same line ?
|
@yourfavDev You added this line https://github.com/ebarlas/microhttp/pull/29/changes#diff-704520638ff99a560ceba86cf170d3f15a8d27ea7017a1c4fdf2fec5da579b9dR18 and that is what made the rest of your changes needed. Just delete that line. |
Couldnt compile because it used the Java logs handler not the Handler Interface. Maven successfully compiles the code now. in JDK24