get_statistic() reads Satterthwaite df as t-values for rlmerMod after an emmeans call - #1219
Merged
Conversation
… an emmeans call Fixes #1218
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the robustlmm::rlmer() + emmeans interaction where get_statistic() could start extracting Satterthwaite degrees of freedom (df) instead of the t statistic after emmeans populates cached DF information (Issue #1218).
Changes:
- Added an S3 method
get_statistic.rlmerMod()that selects the statistic column by name ("t value") rather than by position. - Added a regression test reproducing the
emmeans::emtrends()caching scenario to ensure statistics remain stable. - Documented the fix in
NEWS.mdand bumped the development version.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/testthat/test-rlmer.R | Adds a regression test covering the emmeans caching scenario for rlmerMod. |
| R/get_statistic.R | Introduces get_statistic.rlmerMod() to extract the correct statistic column by name. |
| NEWS.md | Notes the bug fix in the development section. |
| NAMESPACE | Registers the new get_statistic,rlmerMod S3 method. |
| DESCRIPTION | Bumps package version to a new development version. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1218