Skip to content

fixes for summary printout #375#385

Merged
rozyczko merged 1 commit into
developfrom
375-html-summary-goodness-of-fit
Jul 27, 2026
Merged

fixes for summary printout #375#385
rozyczko merged 1 commit into
developfrom
375-html-summary-goodness-of-fit

Conversation

@rozyczko

Copy link
Copy Markdown
Member
  • Added record_fit_results method to MultiFitter to allow recording of fit results produced externally, ensuring that attributes like chi2, reduced_chi, and the HTML summary reflect the latest fit state. Passing None clears the state.

  • Refactored the _compute_goodness_of_fit method in Summary to read the reduced chi-square directly from the fitter, making the summary independent of underlying FitResults attribute naming and ensuring consistency.

  • Fixed a typo in the HTML template and its usage, changing num_constriants to num_constraints for correct substitution in summaries.

@rozyczko rozyczko added [scope] bug Bug report or fix (major.minor.PATCH) bugfix Fix to known bug [priority] high Should be prioritized soon labels Jul 27, 2026
@codecov

codecov Bot commented Jul 27, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.00%. Comparing base (5e14e7f) to head (266f677).

Files with missing lines Patch % Lines
src/easyreflectometry/summary/summary.py 0.00% 7 Missing ⚠️
src/easyreflectometry/fitting.py 0.00% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop    #385   +/-   ##
=======================================
  Coverage     0.00%   0.00%           
=======================================
  Files           42      42           
  Lines         3573    3573           
=======================================
  Misses        3573    3573           
Flag Coverage Δ
integration 0.00% <0.00%> (ø)
unittests 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/easyreflectometry/summary/html_templates.py 0.00% <ø> (ø)
src/easyreflectometry/fitting.py 0.00% <0.00%> (ø)
src/easyreflectometry/summary/summary.py 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rozyczko
rozyczko merged commit 90fed4f into develop Jul 27, 2026
56 of 63 checks passed
@rozyczko
rozyczko deleted the 375-html-summary-goodness-of-fit branch July 27, 2026 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Fix to known bug [priority] high Should be prioritized soon [scope] bug Bug report or fix (major.minor.PATCH)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant