added fix for #281#282
Merged
rozyczko merged 1 commit intoJul 27, 2026
Merged
Conversation
rozyczko
added
[scope] bug
damskii9992
approved these changes
Jul 27, 2026
damskii9992
left a comment
damskii9992
left a comment
Contributor
There was a problem hiding this comment.
LGTM
Although I find it really stupid that we keep 2 copies of each paramters value stored. One in the Parameter and one in the interface. We should just remove the one in the interface and have the interface get its value from the Parameter instead of having this stupid syncronization, but that is a task for later :/
rozyczko
deleted the
281-dependent-parameters-does-not-update-the-calculator
branch
July 27, 2026 12:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dependent parameters did not properly push their updated values to a callback when their dependencies changed.
This fixes it by calling the callback set function with the updated value any time the value changes.