format extension names in module files with exts_formatter function - #5186
Open
smoors wants to merge 5 commits into
Open
format extension names in module files with exts_formatter function#5186smoors wants to merge 5 commits into
exts_formatter function#5186smoors wants to merge 5 commits into
Conversation
smoors
changed the title
exts_formatter function
boegel
reviewed
Jul 29, 2026
|
|
||
| if formatted: | ||
| formatter = self.cfg.get('exts_formatter') | ||
| if formatter: |
Member
There was a problem hiding this comment.
Can/should we check whether formatter is indeed a function, and throw a sensible error if not?
Without that, error messages produced when say exts_formatter = True is used will be quite nasty/confusing...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
will do nothing without companion easyblock PR (so can be safely merged):
exts_formatterparam to allow formatting extension names in module files easybuild-easyblocks#4125but it needs to be merged to make the easyblock PR work.