Skip to content

Set Cargo variables also for extensions - #3576

Merged
Micket merged 2 commits into
easybuilders:developfrom
Flamefire:20250205103950_new_pr_cargo
Feb 12, 2025
Merged

Set Cargo variables also for extensions#3576
Micket merged 2 commits into
easybuilders:developfrom
Flamefire:20250205103950_new_pr_cargo

Conversation

@Flamefire

@Flamefire Flamefire commented Feb 5, 2025

Copy link
Copy Markdown
Contributor

(created using eb --new-pr)

This is required for e.g. CargoPythonBundle as otherwise $CARGO_HOME won't be set for the extensions.

I also noticed a fix for checksums in dict format I didn't include in #3483
I split that to a separate commit but still included it here.

Test Report

We usually use `{'source': checksum}` for checksums so `src['checksum']`
might return such a dict instead of a checksum.
This can be observed in `uv-0.2.30-GCCcore-13.3.0.eb`:
```
{'reqwest-middleware-0.3.2-21ceec9a5fd2e8d6f71c3ea2999078fecbd13cbe.tar.gz': None}
{'reqwest-retry-0.7.0-21ceec9a5fd2e8d6f71c3ea2999078fecbd13cbe.tar.gz': None}
```

Unpack such dicts via a helper method.

@Micket Micket left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Micket Micket added the bug fix label Feb 5, 2025
@Micket Micket added this to the release after 4.9.4 milestone Feb 5, 2025
@Micket
Micket merged commit 6e92d69 into easybuilders:develop Feb 12, 2025
@Flamefire
Flamefire deleted the 20250205103950_new_pr_cargo branch February 13, 2025 08:09
@boegel boegel modified the milestones: release after 4.9.4, 5.0.0 Mar 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants