[Snyk] Security upgrade eslint from 8.11.0 to 9.26.0#47
Conversation
The following vulnerabilities are fixed with an upgrade: - https://snyk.io/vuln/SNYK-JS-ESLINT-15102420
Summary of ChangesHello @earthiverse, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request automatically updates the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request, automatically generated by Snyk, upgrades eslint from v8.11.0 to v9.26.0 to fix a security vulnerability. While this is a necessary security update, it introduces a breaking change. The upgrade to ESLint v9 requires corresponding major version upgrades for related packages like @typescript-eslint/eslint-plugin and @typescript-eslint/parser, which have not been included in this PR. I've left a critical comment detailing the necessary changes to ensure your linting setup doesn't break.
| "@typescript-eslint/parser": "^5.16.0", | ||
| "copyfiles": "^2.4.1", | ||
| "eslint": "^8.11.0", | ||
| "eslint": "^9.26.0", |
There was a problem hiding this comment.
Upgrading eslint to v9 is a major version bump with breaking changes. The current versions of @typescript-eslint/eslint-plugin (^5.16.0) and @typescript-eslint/parser (^5.16.0) are not compatible with ESLint v9 and will break your linting setup.
To resolve this, you must also upgrade these packages to a compatible version (v7+). Please update your devDependencies as follows:
"@typescript-eslint/eslint-plugin": "^7.0.0",
"@typescript-eslint/parser": "^7.0.0",
"eslint": "^9.26.0",Remember to run npm install to update package-lock.json after making these changes.
Snyk has created this PR to fix 1 vulnerabilities in the npm dependencies of this project.
Snyk changed the following file(s):
package.jsonpackage-lock.jsonVulnerabilities that will be fixed with an upgrade:
SNYK-JS-ESLINT-15102420
Important
Note: You are seeing this because you or someone else with access to this repository has authorized Snyk to open fix PRs.
For more information:
🧐 View latest project report
📜 Customise PR templates
🛠 Adjust project settings
📚 Read about Snyk's upgrade logic
Learn how to fix vulnerabilities with free interactive lessons:
🦉 Learn about vulnerability in an interactive lesson of Snyk Learn.