Skip to content

Enable S (flake8-bandit) ruleset and fix violations. #1404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mfisher87 merged 3 commits into from
Jul 29, 2026
Merged

Enable S (flake8-bandit) ruleset and fix violations. #1404

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e4ebaf7
fixed errors and violations as a result of enbaling S rulesets
Sherwin-14 Jul 27, 2026
18928a4
Merge branch 'main' into S
Sherwin-14 Jul 27, 2026
11261d8
Remove duplicate ignore
mfisher87 Jul 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion earthaccess/store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ def make_instance(
# NOTE: This uses the first data_link listed in the granule. That's not
# guaranteed to be the right one.
return earthaccess.open([granule])[0]
return EarthAccessFile(loads(data), granule)
return EarthAccessFile(loads(data), granule) # noqa: S301


def _get_url_granule_mapping(
Expand Down
8 changes: 1 addition & 7 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,20 +211,14 @@ ignore = [
"D417",
"E501",
"FIX002",
"PGH003",
"PT006",
"PT007",
"PT009",
"PT011",
"PT012",
"PT017",
"PT027",
"S101",
"S108",
"S113",
"S301",
"S603",
"S607",
"TD002",
"TD003",
"TD004"
Expand All @@ -236,7 +230,7 @@ combine-as-imports = true
[tool.ruff.lint.per-file-ignores]
# Allow `print` and `pprint` in notebooks
"*.ipynb" = ["T201", "T203", "N803", "RET504", "ERA001", "PLR2004", "PD002", "PD010", "PD011", "EM", "ARG001", "BLE001", "FBT","TRY003"]
"tests/**/*.py" = ["PLR2004", "FBT", "INP001", "SLF001"]
"tests/**/*.py" = ["PLR2004", "FBT", "INP001", "SLF001", "S101", "S108", "S301", "S603", "S607"]
"scripts/**/*.py" = ["INP001"]

[tool.ruff.lint.pydocstyle]
Expand Down
7 changes: 6 additions & 1 deletion scripts/yamlfmt.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,13 @@
"""

import platform
import shutil
import subprocess
import sys

yamlfmt_path = shutil.which("yamlfmt")
if yamlfmt_path is None:
sys.exit("yamlfmt not found on PATH")

if platform.system() != "Windows":
sys.exit(subprocess.call(["yamlfmt", *sys.argv[1:]]))
sys.exit(subprocess.call([yamlfmt_path, *sys.argv[1:]])) # noqa: S603
Loading