SDSTOR-21465: scrubber phase 1#413
Open
JacksonYao287 wants to merge 3 commits into
Open
Conversation
JacksonYao287
force-pushed
the
scrubber-phase-1
branch
from
0f155d8 to
f3cc39a
Compare
JacksonYao287
requested review from
Besroy,
Hooper9973,
koujl,
xiaoxichen,
yuwmao and
zhiteng
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## stable/v4.x #413 +/- ##
==============================================
Coverage ? 53.14%
==============================================
Files ? 39
Lines ? 6902
Branches ? 943
==============================================
Hits ? 3668
Misses ? 2823
Partials ? 411 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
JacksonYao287
force-pushed
the
scrubber-phase-1
branch
3 times, most recently
from
b25a7a3 to
83d0375
Compare
JacksonYao287
force-pushed
the
scrubber-phase-1
branch
from
83d0375 to
fdf3a0c
Compare
Hooper9973
reviewed
May 15, 2026
JacksonYao287
force-pushed
the
scrubber-phase-1
branch
2 times, most recently
from
1cec0d0 to
96736e5
Compare
JacksonYao287
force-pushed
the
scrubber-phase-1
branch
6 times, most recently
from
fe2f1c0 to
dfdb099
Compare
JacksonYao287
force-pushed
the
scrubber-phase-1
branch
from
dfdb099 to
4ac2c8a
Compare
xiaoxichen
reviewed
Jun 11, 2026
| } | ||
|
|
||
| void ScrubManager::add_scrub_req(std::shared_ptr< scrub_req > req) { | ||
| m_scrub_req_executor->add([this, req = std::move(req)]() { handle_scrub_req(req); }); |
Collaborator
There was a problem hiding this comment.
m_scrub_req_executor can be null
xiaoxichen
requested changes
Jun 11, 2026
xiaoxichen
left a comment
xiaoxichen
left a comment
Collaborator
There was a problem hiding this comment.
The NPE bug should be fixed before merging, other part LGTM.
The NPE can be triggered if some SM enabled scrubbing during config change/upgrade, then causing cluster wide crashing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.