Fix stay_in_settings_menu loop error with conditional - #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
while stay_in_settings_menuloop insrc/app.rsneeds an additional conditional to prevent errors when the--interactionargument is used.Problem 1:
Settings -> Station Mode -> Disable Adapter -> Esc Key
stay_in_settings_menu = trueand the program remains in thewhile stay_in_settings_menuloop and errors out atself.adapter.refresh().await?;. The adapter device is powered off andself.adapter.refresh()exits with errors. The program needs to exit the loop to exit gracefully.Problem 2:
Settings -> Station Mode -> Settings -> Access Point Mode -> Disable Adapter -> Esc Key
This causes multiple problems as the menu remains in the Settings menu. Disable Adapter is showing even though it's already disabled. If you press Esc it cycles between Power On Device menu and the Settings menu. If you select Disable Adapter then press Esc you're stuck in an infinite loop of doing that. If you select Access Point then press Esc you go back to the Power on Device menu.
Solution:
Add at
line 407insrc/app.rs:When pressing both Esc during the Power on Device menu and when pressing Access Point Mode,
self.running = false, so settingstay_in_settings_menu = falseexits the loop and keeps the program executing as intended. Problem 1 exits gracefully and problem 2 returns to the main menu and continues functioning properly. Whenself.running = true, remaining in the loop keeps the program functioning properly.