Repository navigation
feat: Ginkgo/Gomega envtest integration test suite for all three operator reconcilers - #146
Merged
Merged
Conversation
…operator reconcilers Implements the full envtest integration test suite requested in #34: - operator/test/integration/ — 16 Ginkgo/Gomega specs covering SchemaReconciler, ToolReconciler, and HandlerReconciler against a live kube-apiserver + etcd - Uses noopScaledObjectAdapter since KEDA CRDs are not installed in envtest - Each spec runs in its own isolated namespace with DeferCleanup teardown - All async assertions use gomega.Eventually with 10–50s timeout / 500ms poll - Makefile: adds test-integration target using setup-envtest for k8s 1.32.0 - CI: adds .github/workflows/integration-test.yml job running on PRs to operator/ - Fixes watches_envtest_test.go: updated to current NewHandlerReconciler signature (added skills/kapeproxy/skillConfigMap params), corrected KapeConfig fields, added missing Properties to KapeSchema and LastTransitionTime to status conditions, and ensured the skill is in Spec.Skills so the rollout-hash changes on update Closes #34 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
operator/test/integration/— 16 Ginkgo/Gomega specs running SchemaReconciler, ToolReconciler, and HandlerReconciler against a live kube-apiserver + etcd via envtestDeferCleanupteardown; all async assertions usegomega.Eventuallywith ≥10s timeout and 500ms pollnoopScaledObjectAdapter) since KEDA CRDs are not in the envtest clusteroperator/controller/watches_envtest_test.go: updated to currentNewHandlerReconciler12-param signature, correctedKapeConfigfield names, added missingPropertiestoKapeSchema, addedLastTransitionTimeto status conditions, and wired the skill intoSpec.Skillsso the rollout-hash actually changes on skill updatemake test-integrationtarget (usessetup-envtestto download k8s 1.32.0 binaries).github/workflows/integration-test.ymlCI job running on PRs touchingoperator/orcrds/Test coverage
Test plan
make test-integrationpasses locally (KUBEBUILDER_ASSETSrequired)go test ./operator/...(no envtest tag) still passes — no regressionsintegration-testjob runs on this PRCloses #34
🤖 Generated with Claude Code