Conversation
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Changed
const size = Astro.props.sizetoconst { size, ...props} = Astro.propsand then on the component changed{....Astro.props}to{...props}. This was causing certain properties to be overwritten and now will preserve any other SVG attributes passed in such as stroke.Also updated the build.js file to only replace the color comment and not the full
fill=<!--color-->;Changed export type Props to import type Props so type-hinting could be inferred and allow SVG props to be passed in.
Also changed the 'currentColor' on the fill. No color was set on a parent element, so this was not doing anything.