Update the IDE help system to use the opendylan.org web site - #1825
Merged
Conversation
No one puts Help buttons on toolbars in this day and age. * sources/environment/tools/primary-frame.dylan (make-help-tool-bar-buttons): Do not add a Help button to the environment toolbar.
The HTML Help build pipeline was always someone ad hoc, and we haven't had an up-to-date version in many years. These changes replace the included HTML Help file with opening the opendylan.org web site. * sources/lib/release-info/common-info.dylan ($release-help-web-address): New constant. ($help-filename): Remove. (release-help-web-address): New function. (release-help-location): Remove. * sources/lib/release-info/module.dylan (module release-info): Export release-help-web-address and remove release-help-location. * sources/environment/tools/help.dylan (help-source open-dylan): Point to release-help-web-address(). ($download-doc-page): Remove. (settings <documentation-settings>, $documentation-settings): Remove. (online-doc-installed?): Remove. (online-doc-location): Remove. (frame-help-contents-and-index): Change to open the release help web address. (frame-help-on-keyword): Change to open the release help web address with the keyword as a query string. (do-frame-help): Remove.
* build/packages/win32-nsis/build-installer.bat: Remove check for the existence of opendylan.chm (the HTML Help bundle file). * build/packages/win32-nsis/opendylan.nsi: Remove the install of the opendylan.chm file and associated registry changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.