<table> implementation improvements - #1822
Merged
Merged
Conversation
* sources/dylan/table.dylan ($entry-counts): Replace the sequence of primes used for table vector growth target sizes with a faster-growing one that allows more entries (463_830_313 vs 9_562_387).
* sources/dylan/table.dylan (search-for-entry-count, compute-entry-count): Mark elements retrieved from the $entry-counts constant vector as integer using primitive-the to improve dispatch performance.
cgay
reviewed
Jun 23, 2026
| // needed number of entries. | ||
| if (lower = upper) | ||
| vector-element($entry-counts, lower); | ||
| primitive-the(<integer>, vector-element($entry-counts, lower)) |
Member
There was a problem hiding this comment.
Just curious, couldn't this also be achieved by making $entry-counts be a limited(<vector>, of: <integer>)?
Member
Author
There was a problem hiding this comment.
Just curious, couldn't this also be achieved by making
$entry-countsbe alimited(<vector>, of: <integer>)?
Not quite as easily, you'd have to initialize it with as(limited(<vector>, of: <integer>), #[...]) which would have an initialization-time cost. I don't think the compiler can do the conversion at compile time (yet).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.