ci: land the Worker config and runtime tests that missed the merge - #29
Merged
Conversation
Commits the custom domain routes and workers_dev fallback that the cutover added, so the deployed configuration lives in git rather than only on Cloudflare. Adds a second CI job that runs the e2e suite against workerd instead of the Vite dev server, and fails the build if wrangler reports a missing Node builtin. Both bugs that surfaced during the migration were invisible to the existing job: the nodejs_compat flag throws at runtime rather than at build, and a prerendered feed served the wrong content type. The old suite passed green through both. The nodejs_compat guard is verified by removing the flag and confirming the job fails, so it is not a check that can only pass.
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
cjdyas-design | 87fff7b | Commit Preview URL Branch Preview URL |
Jul 31 2026, 05:48 PM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #28 merged a stale head, so three things never landed: the prettier fix that was failing CI, the custom domain routes in wrangler.jsonc, and the CI job that runs the e2e suite against workerd.
That left main describing a Worker configuration that does not match what is actually deployed, which is the part worth correcting.
The new CI job runs the same Playwright suite against workerd rather than the Vite dev server, and fails if wrangler reports a missing Node builtin. Both bugs found during the migration were invisible to the existing job: nodejs_compat throws at runtime rather than at build, and a prerendered feed served the wrong content type. The guard is verified by removing the flag and confirming the job fails, so it is not a check that can only pass.
npm run check exits 0 and the build is clean.