Skip to content

[major] Fix length error messages#2506

Open
PelayoFelgueroso wants to merge 9 commits into
masterfrom
PelayoFelgueroso/length-errors
Open

[major] Fix length error messages#2506
PelayoFelgueroso wants to merge 9 commits into
masterfrom
PelayoFelgueroso/length-errors

Conversation

@PelayoFelgueroso

Copy link
Copy Markdown
Collaborator

Checklist
(Check off all the items before submitting)

  • Build process is done without errors. All tests pass in the /lib directory.
  • Self-reviewed the code before submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Purpose
Fix length error messages at formFields

Comment thread apps/website/screens/guidelines/localization/LocalizationPage.tsx Outdated
Comment thread apps/website/screens/guidelines/localization/LocalizationPage.tsx Outdated
Comment thread packages/lib/src/text-input/utils.ts Outdated
Comment thread packages/lib/src/common/variables.ts Outdated
Comment thread packages/lib/src/text-input/TextInput.test.tsx
Comment thread packages/lib/src/textarea/Textarea.tsx Outdated
setPortalContainer(document?.getElementById(`${inputId}-portal`));
}, []);

const getLengthErrorMessage = (value: string) => {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave this function in utils.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants