Skip to content

[minor] New Message Input component implementation#2504

Open
PelayoFelgueroso wants to merge 25 commits into
masterfrom
PelayoFelgueroso/message-input
Open

[minor] New Message Input component implementation#2504
PelayoFelgueroso wants to merge 25 commits into
masterfrom
PelayoFelgueroso/message-input

Conversation

@PelayoFelgueroso

Copy link
Copy Markdown
Collaborator

Checklist
(Check off all the items before submitting)

  • Build process is done without errors. All tests pass in the /lib directory.
  • Self-reviewed the code before submitting.
  • Meets accessibility standards.
  • Added/updated documentation to /website as needed.
  • Added/updated tests as needed.

Purpose
Implemente the new message input component based on the design.

Comment thread packages/lib/src/message-input/MessageInput.tsx Outdated
Comment thread packages/lib/src/message-input/MessageInput.tsx Outdated
Comment thread packages/lib/src/message-input/MessageInput.tsx Outdated
Comment thread packages/lib/src/message-input/MessageInput.tsx Outdated
Comment thread packages/lib/src/message-input/MessageInput.tsx Outdated
Comment thread packages/lib/src/select/utils.ts Outdated

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review all the visual test cases, there are multiple that does not make sense as visual tests.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

Comment thread packages/lib/src/message-input/MessageInput.test.tsx
Comment thread packages/lib/src/message-input/types.ts Outdated
};

recognition.onerror = (event: SpeechRecognitionErrorEvent) => {
console.error("Speech recognition error:", event.error);

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This error should be sent to the message input to display any possible error related to the voice transcript.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants