support charms that communicate with the workload or set workload version#19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main change: Support charms that try to communicate with the workload at
0.0.0.0. In a real K8s deployment, this works because the charm container and workload container are in the same pod. But with jjx, the charm code is running outside the docker container (under bubblewrap). This poses a challenge.One solution would be to ask Docker to use the host network. I rejected that solution because I don't want a workload to be able to bind to arbitrary ports on my system.
After a lengthy investigation, Copilot produced this solution: At hook time, determine the IP of the container. Then inject a Python shim that rewrites connections to
0.0.0.0so that they point at the container instead. I'm good with this solution.We also introduced an environment variable
JJX_DOCKER_PUBLISHthat can be set (at thepytestlevel) in case someone wants to publish the workload to a port on the host network.