Repository navigation
feat: pass the original-to-duplicate id map to onDuplicate - #722
Open
barnabasmolnar wants to merge 5 commits into
Open
barnabasmolnar wants to merge 5 commits into
barnabasmolnar wants to merge 5 commits into
Conversation
Duplicating copies customData as is, so any element ids kept there still point at the originals. Hand the host the origIdToDuplicateId map that duplicateElements already builds, as a third onDuplicate argument, on every duplication path (duplicate action, alt-drag, paste, library insert) so it can repoint them. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
dwelle
force-pushed
the
master
branch
2 times, most recently
from
September 21, 2026 08:45
150a4a3 to
10a08e5
Compare
dwelle
force-pushed
the
master
branch
3 times, most recently
from
October 1, 2026 14:58
cf91ce7 to
aef0851
Compare
dwelle
force-pushed
the
master
branch
4 times, most recently
from
October 12, 2026 12:37
63d8bbe to
ddee6e5
Compare
dwelle
force-pushed
the
master
branch
2 times, most recently
from
October 20, 2026 10:19
5e7e32b to
f499d71
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Duplicating copies customData as is, so any element ids kept there still point at the originals. Hand the host the origIdToDuplicateId map that duplicateElements already builds, as a third onDuplicate argument, on every duplication path (duplicate action, alt-drag, paste, library insert) so it can repoint them.