Skip to content

Remove obsolete DSN identifier #429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Invvard wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Remove obsolete DSN identifier #429

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
976c0b0
Remove deprecated endpoint request
Invvard Jul 3, 2026
8449375
Remove deprecated endpoint request call
Invvard Jul 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 0 additions & 32 deletions pyhilo/api.py
100755 → 100644
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -715,38 +715,6 @@ async def get_seasons(self, location_id: int) -> list[dict[str, Any]]:

return all_seasons

async def get_gateway(self, location_id: int) -> dict[str, Any]:
"""Gets info about the Hilo hub (gateway)"""
url = self._get_url("Gateways/Info", location_id=location_id)
LOG.debug("Gateway URL is %s", url)
req = await self.async_request("get", url)
saved_attrs = [
"zigBeePairingActivated",
"zigBeeChannel",
"firmwareVersion",
"onlineStatus",
"lastStatusTime",
"disconnected",
]

gw = {
"name": "Hilo Gateway",
"Disconnected": {"value": not req[0].get("onlineStatus") == "Online"},
"type": "Gateway",
"category": "Gateway",
"supportedAttributes": ", ".join(saved_attrs),
"settableAttributes": "",
"id": 1,
"identifier": req[0].get("dsn"),
"sdi": req[0].get("sdi"),
"provider": 1,
"model_number": "EQ000017",
"sw_version": req[0].get("firmwareVersion"),
}
for attr in saved_attrs:
gw[attr] = {"value": req[0].get(attr)}
return gw

async def get_weather(self, location_id: int) -> dict[str, Any]:
"""This will return the current weather like in the app
https://api.hiloenergie.com/Automation/v1/api/Locations/XXXX/Weather
Expand Down
14 changes: 1 addition & 13 deletions pyhilo/devices.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ def generate_device(self, device: dict) -> HiloDevice:
return dev

async def update(self) -> None:
"""Update device list from SignalR cache + gateway from REST."""
"""Update device list from SignalR cache."""
# Get devices from SignalR cache (already populated by DeviceListInitialValuesReceived)
cached_devices = self._api.get_device_cache(self.location_id)
generated_devices = []
Expand All @@ -110,17 +110,6 @@ async def update(self) -> None:
if dev not in self.devices:
self.devices.append(dev)

# Append gateway from REST API (still available)
try:
gw = await self._api.get_gateway(self.location_id)
LOG.debug("Generating gateway device %s", gw)
gw_dev = self.generate_device(gw)
generated_devices.append(gw_dev)
if gw_dev not in self.devices:
self.devices.append(gw_dev)
except Exception as err:
LOG.error("Failed to get gateway: %s", err)

# Now add devices from external sources (e.g. unknown source tracker)
for callback in self._api._get_device_callbacks:
try:
Expand Down Expand Up @@ -183,7 +172,6 @@ async def async_init(self) -> None:

Gets location IDs from REST API, then waits for the SignalR hub
to deliver the device list via DeviceListInitialValuesReceived.
The gateway is appended from REST.
"""
LOG.info("Initialising: getting location IDs")
location_ids = await self._api.get_location_ids()
Expand Down