Repository navigation
Conversation
The band handed to a hosted island was the bar plus its edge spacing, so on a floating bar the pill was too tall, off-center and poked above the bar. Pass the visible bar and the spacing as an offset instead. The bar window shrinks back after the island closes, and Hyprland draws the old buffer squeezed into the new size for a frame. Resize the buffer first and only then the layer surface. This waits 150 ms after the close, because a frame rendered at the old size that lands after the resize is squeezed the same way.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Two fixes for the island widget in a bar.
The pill was off-center on a floating bar and poked above its top edge, because it was sized and placed from the bar plus its edge spacing. It now uses the actual bar for its sizing.
The bar also flickered for a frame after the island closed on Hyprland. The bar window shrinks back at that point, and Hyprland showed the old content squeezed into the new size. The window content now shrinks first, shortly after the close, the same way #4129 does it for popouts.
Type of change
Related issues
Screenshots / video
Checklist
I18n.tr()with translator context, reusing existing terms where possiblemake fmt, added/updated tests,make testpasses, andgo mod tidyis cleanmake lint-qmlwith no new warnings