[DaniCatGames]

Description

Add a firewall tab under Settings -> Network -> Firewall that allows basic configuration of both firewalld and ufw. Firewalld allows changing the zones of interfaces, and managing the rules of a zone. Ufw allows changing default incoming/outgoing and its rules are global instead of per zone. Raw/complicated zone/rule editing is not here on purpose to keep it usable and simple, while still providing 99% of the functionality most people will ever need.

Type of change

• Bug fix (non-breaking change that fixes an issue)
• New feature (non-breaking change that adds functionality)
• Breaking change (fix or feature that changes existing behavior)
• Refactor / internal cleanup
• Documentation
• Other

Related issues

None

Screenshots / video

Checklist

• My code follows the conventions in CONTRIBUTING.md
• I have tested my changes locally
• New user-facing strings are wrapped in I18n.tr() with translator context, reusing existing terms where possible
• Go changes: ran make fmt, added/updated tests, make test passes, and go mod tidy is clean
• QML changes: ran make lint-qml with no new warnings
• I have opened a corresponding pull request in dux-docs to document any new behaviors: https://github.com/duxlabs-dev/dux-docs

[Conava]

Really nice feature. I hope it gets merged, I would integrate it into #3727 too (if that ever gets in).
But I think this needs a docs PR

[apollo79]

Design-wise I would like the status at the top to be a bit more prominent, color-wise maybe. Maybe also use the shield icon with checkmaek to indicate the secured status.

• can one create new zones?
• is it possible to edit rules? There is only a delete button visible.

Maybe expandable list items can also be used instead of the selector for zone: https://m3.material.io/components/lists/specs#5b4e7e40-f62b-4724-9d22-201672104ed5

The expandable items would be the zones in that case. Just an idea though and might not work out nicely.

Also the "Networks" section doesn't say what the dropdown on the right is. When you aren't familiar with firewalls you wouldn't understand what you are changing there.

[DaniCatGames]

Really nice feature. I hope it gets merged, I would integrate it into #3727 too (if that ever gets in). But I think this needs a docs PR

@Conava What would you want to see in the docs? I was going to open a PR to add it to the optional features section with a quick explanation but would you like anything more?

[Conava]

Really nice feature. I hope it gets merged, I would integrate it into #3727 too (if that ever gets in). But I think this needs a docs PR

@Conava What would you want to see in the docs? I was going to open a PR to add it to the optional features section with a quick explanation but would you like anything more?

No I think a small mention is enough. Just saw that it was missing here, nothing in particular I wanted to see in there.