Repository navigation
Conversation
The override for a bar lived in a list under Interface style, with only a link to it from the bar's settings, while the frame bar and the island satellites had their row on the bar's page. Give every bar the same row in its Surface card and drop the Bars card from Interface style. Island bars had no link at all, so they can now reach it from their own page too. Docks stay in Interface style. The satellite and widget opacity rows now read Opacity with Override below it, like the frame row.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Moves the opacity override of a bar from Interface style to the bar's own page, into its Surface card. The frame bar and the island satellites already had their row there, while a normal bar only had a link to Interface style and an island bar had nothing, so it was hard to find what overrides what. This keeps the override on the settings page of the item it concerns.
The Bars card under Interface style is gone while the Docks one is still there for now. The satellite and widget opacity rows now read "Opacity" with "Override" below it, like the frame row. No new translations needed.
Type of change
Related issues
Screenshots / video
Checklist
I18n.tr()with translator context, reusing existing terms where possiblemake fmt, added/updated tests,make testpasses, andgo mod tidyis cleanmake lint-qmlwith no new warnings