Repository navigation
Add tests for the gaps found by mutation testing - #310
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The tests accurately cover the mutation-testing gaps without changing production behavior.
0 open findings
What changed in this PR
Adds mutation-focused regression tests for hashing and encryption gadgets.
Changes:
- Verifies domain-specific
output_lenbehavior. - Tests rejection of forged ciphertexts.
- Pins encryption gadget constraint counts.
| File | Description |
|---|---|
tests/hash.rs |
Tests HashGadget output-length restrictions. |
tests/hash_errors.rs |
Tests native hash output-length restrictions. |
tests/encryption_gadget.rs |
Tests forgery rejection and gate counts. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
HDauven
force-pushed
the
test/mutation-gaps
branch
from
October 10, 2026 12:02
e6cce35 to
b1d11f9
Compare
Member
Author
|
Force-pushed: squashed into one commit. The tree is unchanged. |
HDauven
marked this pull request as ready for review
October 10, 2026 12:16
moCello
approved these changes
Oct 11, 2026
moCello
left a comment
moCello
left a comment
Member
There was a problem hiding this comment.
APPROVE
Each new test can fail for the reason it states, and the forged cipher-text test has an honest proof as its control.
- One note below, on a discarded
Resultin the gate count test. It does not block the merge.
Mutation testing of dusk-poseidon 0.44.0 found code that no test pins. Each test below fails on the mutant it targets: - Test that the decryption gadget rejects forged cipher-texts - Test that output_len only overrides the other domain - Pin the gate counts of the encryption gadgets
HDauven
force-pushed
the
test/mutation-gaps
branch
from
October 11, 2026 14:51
b1d11f9 to
72547de
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #309.
Tests only, so there is no changelog entry. Each test fails on the mutant it targets and passes on the released dusk-poseidon 0.44.0.