fix(app): remove duplicate Settings lazy import - #1944
Conversation
App.tsx declared Settings twice which broke tsc. Also type the useSessions realtime broadcast callbacks so the frontend typecheck passes again. Co-authored-by: Cursor <cursoragent@cursor.com>
|
@nyxsky404 is attempting to deploy a commit to the durdana3105's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Warning Review limit reached
Next review available in: 59 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Update profile-photo assertions for Supabase storage paths and the 2MB limit, and document /api/upload plus /api/users/upload-photo so docs completeness checks pass. Co-authored-by: Cursor <cursoragent@cursor.com>
|
@nyxsky404 The CI failures on this PR are fixed. Cause: backend tests still expected the old local Fix: aligned The required @durdana3105 Ready for review and merge when you are. |
nyxsky404
left a comment
There was a problem hiding this comment.
Looks good: removes the duplicate Settings lazy import that broke tsc, and tightens the useSessions callback typing.
CI test is green after the upload test/docs alignment commit. LGTM on the feature change — needs a maintainer approval/merge (@durdana3105).
|
Hi @durdana3105 — gentle nudge. This PR is ready for review from my side. I've rebased/kept it current where possible. If CI is red due to unrelated upstream/main issues or deploy previews, the code change itself should still be reviewable. Please review and merge when you can — and add Thank you! |
Summary
App.tsxdeclaredconst Settings = React.lazy(...)twice, sotscfailed with TS2451 before Vite could build.Removed the duplicate and typed the
useSessionsbroadcast/subscribe callbacks that were also blocking typecheck.Testing
npx tsc -p tsconfig.app.json --noEmitnpm run buildFixes #1901
Made with Cursor