Skip to content

fix(sessions): wire SessionCard Join to session deep link - #1942

Merged
durdana3105 merged 2 commits into
durdana3105:mainfrom
nyxsky404:fix/1899-session-card-join-action
Aug 10, 2026
Merged

fix(sessions): wire SessionCard Join to session deep link#1942
durdana3105 merged 2 commits into
durdana3105:mainfrom
nyxsky404:fix/1899-session-card-join-action

Conversation

@nyxsky404

Copy link
Copy Markdown
Contributor

Summary

SessionCard Join had no onClick/href on the learner and mentor dashboards.

  • added optional joinHref on the Session model / card
  • both dashboards pass /sessions?session=:id
  • Sessions page selects that session from the query param
  • missing destination renders a disabled Unavailable button

Testing

  • npx vitest run src/components/SessionCard.test.tsx
  • npx eslint on touched files

Fixes #1899

Made with Cursor

Join was a dead button on dashboard session cards. Point it at
/sessions?session=:id, select that session on load, and show
Unavailable when no destination exists.

Co-authored-by: Cursor <cursoragent@cursor.com>
@vercel

vercel Bot commented Aug 6, 2026

Copy link
Copy Markdown

@nyxsky404 is attempting to deploy a commit to the durdana3105's projects Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitai Bot commented Aug 6, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@nyxsky404, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 59 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 6b958d75-fb47-4b75-a4e8-8dbb0bf57305

📥 Commits

Reviewing files that changed from the base of the PR and between 8c4d292 and 48da313.

📒 Files selected for processing (10)
  • backend/tests/uploadPhoto.test.js
  • docs/api.md
  • src/components/SessionCard.test.tsx
  • src/components/SessionCard.tsx
  • src/hooks/useSessions.ts
  • src/lib/sessionJoinPath.ts
  • src/pages/Dashboard.tsx
  • src/pages/MentorDashboard.tsx
  • src/pages/Sessions.tsx
  • src/types/index.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Update profile-photo assertions for Supabase storage paths and the 2MB limit, and document /api/upload plus /api/users/upload-photo so docs completeness checks pass.

Co-authored-by: Cursor <cursoragent@cursor.com>
@nyxsky404

Copy link
Copy Markdown
Contributor Author

@nyxsky404 The CI failures on this PR are fixed.

Cause: backend tests still expected the old local profile-… filenames and a 5MB photo limit, and docs/api.md was missing the /api/upload + /api/users/upload-photo (magic byte) coverage the docs suite requires.

Fix: aligned backend/tests/uploadPhoto.test.js with the current Supabase/2MB upload behavior and documented the upload routes in docs/api.md.

The required test check is green now. (Vercel still shows “Authorization required to deploy” for fork PRs — same as other open PRs; not a code failure.)

@durdana3105 Ready for review and merge when you are.

@nyxsky404 nyxsky404 left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good: SessionCard Join is wired to a real deep link with an Unavailable fallback, and Sessions honors the query param.

CI test is green after the upload test/docs alignment commit. LGTM on the feature change — needs a maintainer approval/merge (@durdana3105).

@nyxsky404

Copy link
Copy Markdown
Contributor Author

Hi @durdana3105 — gentle nudge.

This PR is ready for review from my side. I've rebased/kept it current where possible. If CI is red due to unrelated upstream/main issues or deploy previews, the code change itself should still be reviewable.

Please review and merge when you can — and add gssoc:approved (+ difficulty/type) if appropriate so it can count for GSSoC.

Thank you!

@durdana3105
durdana3105 merged commit 11b529a into durdana3105:main Aug 10, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upcoming session Join button has no action on learner or mentor dashboards

2 participants