fix: make doubt upvotes forge-proof via secure RPC (#1928)

[atul-upadhyay-7]

Fixes #1928

Problem

• The consolidated doubts INSERT policy is WITH CHECK (true), so any authenticated user can insert a doubt with a fabricated upvotes count and arbitrary attribution.
• The UPDATE policy allows any authenticated user to set upvotes on any doubt to any value (USING (auth.uid() IS NOT NULL)), so ranking can be manipulated directly:

update public.doubts set upvotes = 999999 where id = '<any doubt>';

Changes

New migration 20260805000005_secure_doubt_upvotes.sql:

• Restore the strict INSERT policy (upvotes = 0; anonymous = true ⇒ user_id IS NULL, anonymous = false ⇒ user_id = auth.uid()).
• Drop the loose UPDATE policy and REVOKE UPDATE ON public.doubts FROM anon, authenticated.
• Add doubt_upvotes table (unique per user + doubt) so each user can vote at most once.
• Add SECURITY DEFINER upvote_doubt(p_doubt_id) RPC: records the vote (idempotent on duplicates) and atomically increments upvotes. GRANTed only to authenticated.

Frontend (src/pages/AnonymousDoubts.tsx): the upvote handler now calls supabase.rpc("upvote_doubt", ...) instead of computing and writing the count client-side.

Verification

• npx eslint src/pages/AnonymousDoubts.tsx — clean.
• npm run typecheck — no new errors.
• The existing addDoubt insert (no upvotes field, correct user_id/anonymous pairing) satisfies the restored strict policy.

[vercel]

@atul-upadhyay-7 is attempting to deploy a commit to the durdana3105's projects Team on Vercel.

A member of the Team first needs to authorize it.

[coderabbitai]

Warning

Review limit reached

@atul-upadhyay-7, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 50 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 99f5ff2f-9aa8-415e-b863-078e004afa86

📥 Commits

Reviewing files that changed from the base of the PR and between 880eed9 and 4bd1f7b.

📒 Files selected for processing (2)

• src/pages/AnonymousDoubts.tsx
• supabase/migrations/20260805000005_secure_doubt_upvotes.sql

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[durdana3105]

solve the failing ci test