Repository navigation
feat: webhook circuit breaker - #604
Merged
martinzhames merged 2 commits intoOct 23, 2026
Merged
Conversation
After 5 consecutive delivery failures the circuit opens for the webhook endpoint for 24h: deliveries are skipped and no retries are scheduled. Opening the circuit raises an admin alert and emails the merchant. Admins can reset an open circuit with POST /admin/webhooks/:id/circuit/reset. Closes dupdab#457
|
@MJigah Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
…rcuit-breaker # Conflicts: # src/webhooks/webhooks.module.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
circuitOpenUntiltoWebhook(with migration). After 5 consecutive failures the circuit opens for 24h; the processor skips deliveries and schedules no further retries while it is open. A successful delivery clears it.WEBHOOK_FAILURE, deduped per webhook) and awebhook-circuit-openemail to the merchant when the circuit opens.POST /admin/webhooks/:id/circuit/reset(superadmin) closes the circuit and clears the failure count.Notes
WebhookDeliveryProcessornow injectsAdminAlertServiceandEmailService; existing specs that construct it directly were not updated.Closes #457