Skip to content

Refactor migration check condition in entrypoint script - #958

Merged
maxhelias merged 2 commits into
dunglas:mainfrom
axzx:patch-1
Jul 21, 2026
Merged

Refactor migration check condition in entrypoint script#958
maxhelias merged 2 commits into
dunglas:mainfrom
axzx:patch-1

Conversation

@axzx

@axzx axzx commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@7-zete-7 7-zete-7 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @axzx!

I agree, the current condition doesn't seem obvious.

Comment thread frankenphp/docker-entrypoint.sh Outdated
Co-authored-by: Stanislau Kviatkouski <7-zete-7@users.noreply.github.com>
@zpi12lmm

Copy link
Copy Markdown

I think since changes are being made to migrations, it's also worth adding a condition that migrations are only performed for the main PHP service (usually create from the main PHP service other worker services that have the same entry point, and the execution of migrations can compete with each other).

@maxhelias
maxhelias merged commit 470bfee into dunglas:main Jul 21, 2026
2 checks passed
@maxhelias

Copy link
Copy Markdown
Collaborator

Thanks @zpi12lmm !

@axzx

axzx commented Jul 21, 2026

Copy link
Copy Markdown
Contributor Author

Thanks @zpi12lmm !

@maxhelias thanks for merge:)

@maxhelias

Copy link
Copy Markdown
Collaborator

Oh, sorry, I confused the usernames. Thanks @axzx 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants