Skip to content

wrapper element + elm ui #1

Description

@koenusz

Hi I would like to thank you for an amazing library.

I would like to suggest two additional features. Or maybe it is exposing a little bit more of your internals to the user. First one is an additional element function that allows you to pass childelements. Something like:

el : List ( Html.Attribute msg ) -> List ( Html.Element msg )-> ( Msg -> msg ) -> Html msg
el customAttrs children msgWrapper =
    let
--      attrs : List (Html.Attribute msg)
        attrs =
            Internal.attrs
                |> List.map ( Attr.map (Msg >> msgWrapper) )
    in
    Html.div
        ( customAttrs ++ attrs )
        children 

The other feature I would like to suggest is to expose your attribute function. Something like :

atrrs: ( Msg -> msg ) -> List ( Html.Attribute msg )
attrs  msgWrapper =
            Internal.attrs
                |> List.map ( Attr.map (Msg >> msgWrapper) )

This would be especially useful for people using elm-ui that want to enable touch events to their elm-ui elements.

Thanks again for an amazing lib.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions