Skip to content

feat(spec-review, spec-revise): emit review file + add revise skill - #9

Open
ops-gaurav wants to merge 1 commit into
mainfrom
feat/review-skill-generate-output
Open

feat(spec-review, spec-revise): emit review file + add revise skill#9
ops-gaurav wants to merge 1 commit into
mainfrom
feat/review-skill-generate-output

Conversation

@ops-gaurav

Copy link
Copy Markdown
Member

Summary

  • spec-review now writes a navigable review file at spec/<spec>/reviews/<phase>-review.md (overwrite each run; history in git). The file holds every issue — not just the top 5 — with stable IDs (R-01, R-02, …) and unresolved checkboxes that the new revise skill consumes. The in-chat reply shrinks to a 150–250-word summary pointing at the file.
  • New spec-revise skill (anthropic, openai-codex, cursor) — takes a phase argument (requirements | design | research | tasks), reads the latest review file (disambiguates if multiple exist), asks per-run whether to apply all P0/P1 fixes or walk through each issue, edits the phase doc, bumps a **Revision:** N · **Updated:** YYYY-MM-DD header at the top, and flips resolved checkboxes in the review file with a _(resolved in revision N on YYYY-MM-DD)_ suffix.
  • Adapter parity — same content ported across all three adapters; Cursor MDC keeps its inlined ## References block intact.
  • Docs — top-level README skill count 12→13, new skill-table row, two workflow examples updated, best-practices bullet rewritten. Adapter READMEs and CHANGELOG Unreleased updated. spec-approve notes now point at spec-revise for pre-approval fixes.

Test plan

  • On a spec with a Draft requirements.md, run spec-review phase=requirements → confirm spec/<spec>/reviews/requirements-review.md is written with verdict, strengths, P0/P1/P2 issue groups, and stable R-XX IDs.
  • Re-run spec-review → confirm the file is overwritten (not appended).
  • Run spec-revise phase=requirements with Apply all → confirm phase doc edits land, the Revision: 1 · Updated: header is inserted at the top, and - [ ] items flip to - [x] with the resolved-suffix in the review file.
  • Run spec-revise again with no remaining open issues → confirm it stops cleanly and points at re-running spec-review.
  • Run spec-revise with Walk through mode and try yes/no/skip on different issues → confirm only approved fixes land and skipped ones stay unchecked.
  • Verify on the openai-codex adapter (identical SKILL.md) and the cursor adapter (single .mdc with inlined references) — same behavior described in the skill body.
  • Re-run on design, research, and tasks phases to confirm path parameterization works.

🤖 Generated with Claude Code

spec-review now writes the full audit to spec/<spec>/reviews/<phase>-review.md
with stable R-XX issue IDs and unresolved checkboxes; the in-chat reply
shrinks to a 150-250 word pointer at the file. spec-revise is new: it reads
the latest review file, prompts the user to apply all P0/P1 fixes or walk
through each issue, edits the phase doc, bumps a Revision/Updated header,
and flips resolved checkboxes in the review file for a per-cycle audit
trail. Ported across the anthropic, openai-codex, and cursor adapters;
spec-approve notes updated to point at spec-revise for pre-approval fixes.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant