Skip to content

Add tests for Iceberg snapshot summary.operation labeling#1190

Closed
The-Alchemist wants to merge 1 commit into
duckdb:mainfrom
The-Alchemist:fix/snapshot-summary-operation
Closed

Add tests for Iceberg snapshot summary.operation labeling#1190
The-Alchemist wants to merge 1 commit into
duckdb:mainfrom
The-Alchemist:fix/snapshot-summary-operation

Conversation

@The-Alchemist

@The-Alchemist The-Alchemist commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Upstream already plumbs summary.operation through IcebergAddSnapshot (append / delete / default overwrite).
  • Pass OVERWRITE explicitly for UPDATE snapshot commits.
  • Add SQL coverage: basic_copy.test asserts append; catalog test covers INSERT/DELETE/UPDATE.

Test plan

  • ./build/release/test/unittest test/sql/copy/basic_copy.test
  • Run test_snapshot_operation.test with CATALOG_TEST_CONFIG_SETUP

Main already plumbs append/delete/overwrite through IcebergAddSnapshot; make UPDATE commits pass OVERWRITE explicitly and cover append/delete/overwrite in SQL tests.

Signed-off-by: Karl Pietrzak <karl@medplum.com>
@The-Alchemist
The-Alchemist force-pushed the fix/snapshot-summary-operation branch from 4a5353d to 7525718 Compare July 17, 2026 19:03
@The-Alchemist The-Alchemist changed the title Fix Iceberg snapshot summary.operation for append/delete/update Add tests for Iceberg snapshot summary.operation labeling Jul 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant