[Dev] Use transaction scoped secrets#1188
Open
Tishj wants to merge 5 commits into
Open
Conversation
…s in transaction for tests using read_avro(getvariable(...))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Builds on the in-flight core PR: duckdb/duckdb#23882
We weren't cleaning up vended credentials created for a scan, so now that they are automatically cleaned up, many tests had to change to create explicit transactions to hold onto the credentials for
read_avro(getvariable(...))reads.Future work:
Needing to use
read_avrois a bit of a codesmell, and we should see what we need to extend the metadata functions with to eliminate the need for this