Add AWS-agnostic access-delegation hooks#1118
Open
The-Alchemist wants to merge 2 commits into
Open
Conversation
Introduce a provider-agnostic extension point so external extensions can supply scan-time credentials and mandatory row filters without any AWS/Lake-Formation code living in duckdb-iceberg. - IcebergPluginRegistry (stored on the database ObjectCache) plus an IcebergAccessDelegationProvider interface and dispatch helpers. - Generic mandatory_delegation_filter_* slots on IcebergScanInfo and a DelegationRowFilterOptimizer that re-applies them above LOGICAL_GET. - Dispatch call sites in ATTACH option parsing, table load, scan credential prep, mandatory filter binding, and per-partition refresh. - Opaque per-table delegation state on IcebergTableInformation; a generic access_delegation_provider string + delegation_options passthrough. No AWS SDK, vcpkg, or Lake Formation specifics are added; those live in the separate lake_formation community extension. Signed-off-by: Karl Pietrzak <karl@medplum.com>
An unknown ACCESS_DELEGATION_MODE is treated as the name of an extension that registers an access-delegation provider, which is autoloaded. When no such extension exists the raw autoload failure leaked through; catch it and raise a single clear "Unrecognized access mode" error that also lists the built-in modes. Update the Nessie test to the new message. Signed-off-by: Karl Pietrzak <karl@medplum.com>
The-Alchemist
marked this pull request as ready for review
June 28, 2026 23:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use Case
Goal is to allow authentication using external authentication mechanisms without bloating
duckdb-icebergrepo.For example, to use all S3 Tables features, you need to use AWS Lake Formation auth, basically.
Description
Introduce a provider-agnostic extension point so external extensions can supply scan-time credentials and mandatory row filters without any AWS/Lake-Formation code living in duckdb-iceberg.
IcebergPluginRegistry(stored on the database ObjectCache) plus an IcebergAccessDelegationProvider interface and dispatch helpers.